ci: fix dead if-conditions in build.yml - #528
Merged
Merged
Conversation
The matrix uses depot-ubuntu-latest but conditions checked for ubuntu-latest, silently skipping docs, storybook, and jupyterlab steps. Also removed redundant linting step (already covered by CI workflow). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…karoo Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These steps were silently skipped before (dead if-condition). Now that they run, they expose pre-existing failures. Mark as continue-on-error until properly fixed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
paddymul
added a commit
that referenced
this pull request
Feb 22, 2026
* ci: fix dead if-conditions in build.yml, remove redundant lint step The matrix uses depot-ubuntu-latest but conditions checked for ubuntu-latest, silently skipping docs, storybook, and jupyterlab steps. Also removed redundant linting step (already covered by CI workflow). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: update old repo URLs from paddymul/buckaroo to buckaroo-data/buckaroo Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * ci: add continue-on-error to previously-hidden build.yml test steps These steps were silently skipped before (dead if-condition). Now that they run, they expose pre-existing failures. Mark as continue-on-error until properly fixed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
depot-ubuntu-latestbut step conditions checkedubuntu-latestTest plan
🤖 Generated with Claude Code